fix: early_stop patience counts epochs not steps
This commit is contained in:
@@ -116,7 +116,7 @@ class _FakeState:
|
||||
eval_prev_run_id: str
|
||||
baseline_skills_version: str
|
||||
baseline_prompts_version: str
|
||||
steps_since_best_improved: int
|
||||
epochs_since_best_improved: int
|
||||
epoch_start_skills: str
|
||||
changed_task_types_this_epoch: set[str]
|
||||
rejected_buffer: dict[str, list[RejectedEdit]]
|
||||
@@ -135,7 +135,7 @@ def _make_state() -> _FakeState:
|
||||
eval_prev_run_id="run-abc",
|
||||
baseline_skills_version="v1",
|
||||
baseline_prompts_version="v1",
|
||||
steps_since_best_improved=2,
|
||||
epochs_since_best_improved=2,
|
||||
epoch_start_skills="v1",
|
||||
changed_task_types_this_epoch={"temporal", "causal"},
|
||||
rejected_buffer={"temporal": [_make_rejected_edit()]},
|
||||
@@ -201,7 +201,7 @@ class TestSerializeDeserializeRoundtrip:
|
||||
assert restored["eval_prev_run_id"] == state.eval_prev_run_id
|
||||
assert restored["baseline_skills_version"] == state.baseline_skills_version
|
||||
assert restored["baseline_prompts_version"] == state.baseline_prompts_version
|
||||
assert restored["steps_since_best_improved"] == state.steps_since_best_improved
|
||||
assert restored["epochs_since_best_improved"] == state.epochs_since_best_improved
|
||||
assert restored["epoch_start_skills"] == state.epoch_start_skills
|
||||
assert restored["changed_task_types_this_epoch"] == state.changed_task_types_this_epoch
|
||||
assert restored["gate_cooldown"] == state.gate_cooldown
|
||||
|
||||
Reference in New Issue
Block a user